Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect private properties #338

Merged
merged 3 commits into from
May 22, 2024
Merged

Protect private properties #338

merged 3 commits into from
May 22, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 22, 2024

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC? ✔️/❌
Fixed issues #308

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 60.37736% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 87.36%. Comparing base (c5a5081) to head (6283133).

Current head 6283133 differs from pull request most recent head afadc6b

Please upload reports for the commit afadc6b to get more accurate results.

Files Patch % Lines
src/AbstractActiveRecord.php 56.75% 16 Missing ⚠️
src/BaseActiveRecord.php 66.66% 4 Missing ⚠️
src/Trait/MagicPropertiesTrait.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #338      +/-   ##
============================================
- Coverage     87.41%   87.36%   -0.05%     
- Complexity      603      604       +1     
============================================
  Files            13       13              
  Lines          1390     1393       +3     
============================================
+ Hits           1215     1217       +2     
- Misses          175      176       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 155a53d into master May 22, 2024
3 checks passed
@Tigrov Tigrov deleted the protect-private-properties branch May 22, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant